Skip to content

.Net Agents - Assistant V2 Migration #7126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 152 commits into from
Aug 12, 2024

Conversation

crickman
Copy link
Contributor

@crickman crickman commented Jul 7, 2024

Motivation and Context

Support Assistant V2 features according to ADR

(based on V2 AI connector migration)

Description

  • Refactored OpenAIAssistantAgent to support all V2 options except: streaming, message-attachment, tool_choice
  • Streaming to be addressed as a separate change
  • Extensive enhancement of unit-tests
  • Migrated samples to use FileClient
  • Deep pass to enhance and improve samples
  • Reviewed and updated test-coverage, generally
agentcov3

Contribution Checklist

@crickman crickman added PR: in progress Under development and/or addressing feedback experimental Associated with an experimental feature enhancement agents labels Jul 7, 2024
@crickman crickman self-assigned this Jul 7, 2024
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Jul 7, 2024
@crickman crickman removed the kernel Issues or pull requests impacting the core kernel label Jul 7, 2024
@markwallace-microsoft markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Jul 7, 2024
crickman and others added 13 commits August 9, 2024 08:44
Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
…ctoryTests.cs

Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
…ctoryTests.cs

Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
@crickman crickman requested a review from RogerBarreto August 9, 2024 17:09
@RogerBarreto RogerBarreto merged commit 9e59698 into feature-connectors-openai Aug 12, 2024
14 checks passed
@RogerBarreto RogerBarreto deleted the feature_agents_openai branch August 12, 2024 14:42
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Open AI has release the _Assistants V2_ API. This builds on top of the
V1 _assistant_ concept, but also invalidates certain V1 features. In
addition, the _dotnet_ API that supports _Assistant V2_ features is
entirely divergent on the `Azure.AI.OpenAI.Assistants` SDK that is
currently in use.

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

ADR describes changes to `Microsoft.SemanticKernel.Agents.OpenAI`
project / package.

Changes prototyped in this PR:
microsoft#7126

PR completion is gated by the V2 connector migration work due to
versioning constraints.

> ADR Reviewed on July 18th, 2024

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄

---------

Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents documentation enhancement experimental Associated with an experimental feature kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews
Projects
Archived in project
4 participants